Document the performance testing commands#22464
Merged
youknowriad merged 3 commits intomasterfrom May 19, 2020
Merged
Conversation
youknowriad
added
the
[Type] Developer Documentation
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
aduth
approved these changes
May 19, 2020
| In addition to that, you can also compare the metrics across branches (or tags or commits) by running the following command `./bin/plugin/cli.js perf [branches]`, example: | ||
|
|
||
| ``` | ||
| ./bin/plugin/cli.js perf master v8.1.0 v8.0.0 |
Member
There was a problem hiding this comment.
Should we have an npm script for this? I know you'd mentioned it in the earlier pull request about npm run performance, but should be there something like npm run release perf master v8.1.0 v8.0.0, aliasing npm run release (or similar name) to ./bin/plugin/cli.js?
Contributor
Author
There was a problem hiding this comment.
yes, we should, I'll keep it for another PR as it impacts several things (release, perf, changelog...)
Co-authored-by: Andrew Duthie <andrew@andrewduthie.com>
Member
|
Great work 💕 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up #22418