Fix license check script to ignore sub-dependencies of ignored packages

[ceyhun]

Description

This is a part of the migration of gutenberg-mobile to the gutenberg repo.
Related to #19861

Updated check-licenses script to parse JSON dependency tree recursively so sub-dependencies of packages passed in --ignore flag are ignored as well.

How has this been tested?

• npm run check-licenses should complete without errors

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR.

[github-actions]

Size Change: 0 B

Total Size: 842 kB

ℹ️ View Unchanged

Filename	Size	Change
build/a11y/index.js	1.02 kB	0 B
build/annotations/index.js	3.62 kB	0 B
build/api-fetch/index.js	4.01 kB	0 B
build/autop/index.js	2.82 kB	0 B
build/blob/index.js	620 B	0 B
build/block-directory/index.js	6.24 kB	0 B
build/block-directory/style-rtl.css	760 B	0 B
build/block-directory/style.css	761 B	0 B
build/block-editor/index.js	105 kB	0 B
build/block-editor/style-rtl.css	10.2 kB	0 B
build/block-editor/style.css	10.2 kB	0 B
build/block-library/editor-rtl.css	7.1 kB	0 B
build/block-library/editor.css	7.1 kB	0 B
build/block-library/index.js	112 kB	0 B
build/block-library/style-rtl.css	7.17 kB	0 B
build/block-library/style.css	7.17 kB	0 B
build/block-library/theme-rtl.css	683 B	0 B
build/block-library/theme.css	685 B	0 B
build/block-serialization-default-parser/index.js	1.88 kB	0 B
build/block-serialization-spec-parser/index.js	3.1 kB	0 B
build/blocks/index.js	57.7 kB	0 B
build/components/index.js	198 kB	0 B
build/components/style-rtl.css	16.9 kB	0 B
build/components/style.css	16.9 kB	0 B
build/compose/index.js	6.66 kB	0 B
build/core-data/index.js	11.4 kB	0 B
build/data-controls/index.js	1.25 kB	0 B
build/data/index.js	8.43 kB	0 B
build/date/index.js	5.47 kB	0 B
build/deprecated/index.js	772 B	0 B
build/dom-ready/index.js	569 B	0 B
build/dom/index.js	3.1 kB	0 B
build/edit-navigation/index.js	3.54 kB	0 B
build/edit-navigation/style-rtl.css	485 B	0 B
build/edit-navigation/style.css	485 B	0 B
build/edit-post/index.js	27.9 kB	0 B
build/edit-post/style-rtl.css	12.3 kB	0 B
build/edit-post/style.css	12.3 kB	0 B
build/edit-site/index.js	10.5 kB	0 B
build/edit-site/style-rtl.css	5.04 kB	0 B
build/edit-site/style.css	5.04 kB	0 B
build/edit-widgets/index.js	7.49 kB	0 B
build/edit-widgets/style-rtl.css	4.66 kB	0 B
build/edit-widgets/style.css	4.66 kB	0 B
build/editor/editor-styles-rtl.css	428 B	0 B
build/editor/editor-styles.css	431 B	0 B
build/editor/index.js	43.3 kB	0 B
build/editor/style-rtl.css	3.48 kB	0 B
build/editor/style.css	3.47 kB	0 B
build/element/index.js	4.65 kB	0 B
build/escape-html/index.js	733 B	0 B
build/format-library/index.js	7.32 kB	0 B
build/format-library/style-rtl.css	502 B	0 B
build/format-library/style.css	502 B	0 B
build/hooks/index.js	2.13 kB	0 B
build/html-entities/index.js	622 B	0 B
build/i18n/index.js	3.56 kB	0 B
build/is-shallow-equal/index.js	711 B	0 B
build/keyboard-shortcuts/index.js	2.51 kB	0 B
build/keycodes/index.js	1.94 kB	0 B
build/list-reusable-blocks/index.js	3.12 kB	0 B
build/list-reusable-blocks/style-rtl.css	226 B	0 B
build/list-reusable-blocks/style.css	226 B	0 B
build/media-utils/index.js	5.29 kB	0 B
build/notices/index.js	1.79 kB	0 B
build/nux/index.js	3.4 kB	0 B
build/nux/style-rtl.css	616 B	0 B
build/nux/style.css	613 B	0 B
build/plugins/index.js	2.67 kB	0 B
build/primitives/index.js	1.49 kB	0 B
build/priority-queue/index.js	789 B	0 B
build/redux-routine/index.js	2.84 kB	0 B
build/rich-text/index.js	14.8 kB	0 B
build/server-side-render/index.js	2.67 kB	0 B
build/shortcode/index.js	1.7 kB	0 B
build/token-list/index.js	1.28 kB	0 B
build/url/index.js	4.02 kB	0 B
build/viewport/index.js	1.84 kB	0 B
build/warning/index.js	1.14 kB	0 B
build/wordcount/index.js	1.17 kB	0 B

_{compressed-size-action}

[pento]

This is a bit of a tricky problem, thanks for diving into it, @ceyhun!

To give some history, the check-licenses script was originally written to parse the output of npm ls --parseable, since that was the easiest method to get a list of all dependencies, and we had no need to worry about which module was included by which. There's certainly no need to stick with this model.

This is clearly a special case worth working around, so I would suggest reworking check-licenses to operate on a more structured dependency model.

I suspect the simplest option will be to switch to npm ls --json, and recursing through the dependency tree. That JSON blob already includes path data for each module, which should allow the existing package.json and license file parsing in check-licenses to be reused in a largely unmodified manner.

path = `${ pkg._where }/node_modules${ pkg._location }`;

With this in place, the dependency tree recursor can just skip any module (and its dependencies) that are passed in the --ignore argument. Since @react-native-community/cli has been manually vetted, it can be included in that argument.

[ceyhun]

Thanks for the suggestion @pento! Pushed the changes implementing that and it seems to work, feel free to take a look.

[pento]

Looks good to me, nice work on the clean rewrite, @ceyhun!

Given the size of the output from npm ls, there's the potential for weird failures in the future, should the dependency tree grow big enough to overrun the buffer size. I'm okay with leaving it as is for now, we can investigate converting it to using a streaming JSON parser if it turns out to be a problem in the future.

[gziolo]

It would be great to cherry-pick changes applied to @wordpress/scripts and merge them to master separately. It looks like a bug in the license check script that might benefit other projects. It would be also nice to include a changelog entry that explains what was fixed:
https://github.com/WordPress/gutenberg/blob/master/packages/scripts/CHANGELOG.md

[Tug]

I agree the script changes should go to master 👍
We can use this PR to target master and revert the other dependency changes, then we'll do another PR that targets the monorepo feature branch and updates master, WDYT @ceyhun ?

[ceyhun]

Sounds good 👍

[gziolo]

Awesome, thanks for all updates 👍

[Tug]