Update npm-package-json-lint from 4.0.3 to 5.0.0#21597
Update npm-package-json-lint from 4.0.3 to 5.0.0#21597gziolo merged 2 commits intoWordPress:masterfrom
Conversation
|
Thanks @sainthkh, none of the new rules in 4.3 or newer requiring setting up, bumping to v5 should not be an issue, I reviewed v5 and added a new rule to it just prior to the v5 release a few days ago, so it should be fine to bump to v5 instead of 4.1.x |
|
Can you also include a note in the CHANGELOG file: Ideally, with the link that has all the changes introduced. If nothing breaks on our side, we can keep it as a minor version bump. |
|
We don't have any related breaking change in So, I've written the change under |
Update package-lock.json
e78c2b9 to
f3288bf
Compare
|
@youknowriad, can you promote @sainthkh to the member role in the repository. He has already a few landed meaningful contributions and some great work in the review process. |
|
done. Thanks for your work @sainthkh |
|
@gziolo @youknowriad Thanks. I'm honored to become a member. |
|
It's well-deserved 😃 |
Description
In #21528, lint mysteriously failed with the message, 'Cannot read property 'toUpperCase' of undefined'. This PR fixes this problem.
The cause was the empty
"description"field inpackage.jsonfile. Check tclindner/npm-package-json-lint#163.How has this been tested?
Manually tested. And it now passes.
Screenshots
N/A
Types of changes
Bug fix
Checklist: