Conversation
|
Size Change: -12 B (0%) Total Size: 903 kB
ℹ️ View Unchanged
|
sirreal
reviewed
Apr 8, 2020
sirreal
reviewed
Apr 8, 2020
6 tasks
ockham
added
[Status] Blocked
75 tasks
ockham
force-pushed
the
add/primitives-types
branch
from
1236a5a to
1de5d3a
Compare
ockham
removed
the
[Status] Blocked
Contributor
Author
|
Snaphots have changed, I'll update. |
sirreal
approved these changes
Apr 10, 2020
Comment on lines
+94
to
+95
| 'aria-hidden': true, | ||
| focusable: false, |
Member
There was a problem hiding this comment.
The React declarations require this change, these props are typed as booleans. I checked in a code sandbox and the following confirms this should produce the same HTML.
This JSX:
<>
<svg aria-hidden="true" focusable="false" />
<svg aria-hidden={ true } focusable={ false } />
</>Produces this HTML:
<svg aria-hidden="true" focusable="false"></svg>
<svg aria-hidden="true" focusable="false"></svg>
Contributor
Author
There was a problem hiding this comment.
Thanks for checking!
| "declarationDir": "build-types" | ||
| }, | ||
| "include": [ "src/**/*" ], | ||
| "references": [ { "path": "../element" } ] |
Member
There was a problem hiding this comment.
That's the only project reference we need 👍
gutenberg/packages/primitives/package.json
Lines 27 to 29 in 7539780
Contributor
Author
|
Thanks Jon! I forgot to add a Changelog entry, will do now. |
Contributor
Author
|
I made one mistake, |
ockham
added a commit
that referenced
this pull request
Apr 10, 2020
Includes a fix to `@wordpress/primitives` to make `SVG`'s `isPressed` prop optional (oversight in #21482).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add types to
@wordpress/primitives.Taking notes from #21248. Part of #18838.
How has this been tested?
Types of changes
Add types.
Checklist:
cc/ @sirreal