Conversation
75 tasks
sirreal
commented
Dec 12, 2019
packages/dom-ready/src/index.js
Outdated
Member
Author
There was a problem hiding this comment.
Subtle behavioral change - this function did not always return void as its type suggested. In this branch, tt would return whatever the callback returned.
Adding the void here so the function always returns undefined.
Member
There was a problem hiding this comment.
Subtle behavioral change - this function did not always return
voidas its type suggested. In this branch, tt would return whatever the callback returned.Adding the
voidhere so the function always returnsundefined.
I think this syntax can be a little unexpected for some people, or at least it was for me the first times I had seen it, but I think it's a nice simple way to guarantee the return type as undefined, as you suggest.
47bcfaf to
8489ad3
Compare
Member
Author
|
Rebased. |
58117e8 to
ac78666
Compare
aduth
approved these changes
Dec 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #18838
Extracted from #18942
Add types to
dom-readypackage.Testing Instructions:
Verify type checking passes: