Remove the use of popular plugins in e2e tests#15940
Conversation
|
Just noting here that merging this would close #13038. |
Yep, it seems like this is not going to happen so we should close 🙁 |
gziolo
left a comment
There was a problem hiding this comment.
These tests have been up for a long time now and didn't prove to be fruitful. Also, it's blocking us from adding warnings to the console as some plugins could trigger console messages.
Yeah, those plugins were added to help catch regressions but it never detected any errors... In fact, we had this case where one of the selectors was removed by accident and our e2e tests didn’t help to catch it. Maybe we should add e2e tests which verify that all public APIs are present? It could be something that would be executed as part of plugin release - similar to how we measure performance.
I don't think we should make this change. There's a ton more context to be found at #15159 and #14289 on this point.
Per #14289 (comment), we can have 15 containers running in parallel for the organization. There's a limit, yes, but the faster each individual task runs, the faster they clear up for another task to use. We should leverage parallelization as much as we can, as long as it helps reduce the average build time in a relatively proportional manner.
This is true, and there's some discussion in #15159 about how we can try to improve this by a combination of (a) reducing build time, (b) preconfiguring Docker images, (c) reusing assets between tasks.
I don't know that anyone should really care about this. My expectation is they should go to the failing task and look at the logs. That there are many tasks with similar names doesn't make a difference in my view. |
This PR blocks #15770
These tests have been up for a long time now and didn't prove to be fruitful. Also, it's blocking us from adding warnings to the console as some plugins could trigger console messages.
While working on this, I also noticed that the e2e test jobs are splitted into 4 separate jobs per role. I assume this is an attempt to speedup the tests but I'd personally question whether it's achieving its purpose.
I don't think I will touch this in this PR but I'd love thoughts. A single job per user would be so much clearer.
Closes #13038.