You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request seeks to double the number of Travis jobs dedicated to running end-to-end tests. In other words, it distributes the number of tests across 4 containers (vs. 2 previously) for each of the "Admin with plugins" and "Author without plugins" variations.
The desired effect here is that the total duration of a build decreases, since the number of end-to-end tests handled by any one Travis container will have lessened by a half.
To the potential question of whether "more containers" is okay or not, see also #14289 (comment) .
The longest job decreases from 12m55s to 10m3s (22% decrease).
The likely explanation here is that we'll encounter diminishing returns on the basis there is a common overhead amongst all these jobs: npm install and npm run build. As noted in #15159, this could be alleviated by pre-generating the build to be used across containers.
That all being said, an improvement is an improvement, and I still think it'd be worthwhile to move forward with this change.
The likely explanation here is that we'll encounter diminishing returns on the basis there is a common overhead amongst all these jobs: npm install and npm run build. As noted in #15159, this could be alleviated by pre-generating the build to be used across containers.
We also should look into how to optimize for Travis the usage of cross-env SCRIPT_DEBUG=false ./bin/reset-e2e-tests.sh. It seems like it might be a part of ./bin/setup-local-env.js since you never re-run the same job without starting Docker from scratch.
It might have a large impact on the duration of each job as well.
We also should look into how to optimize for Travis the usage of cross-env SCRIPT_DEBUG=false ./bin/reset-e2e-tests.sh. It seems like it might be a part of ./bin/setup-local-env.js since you never re-run the same job without starting Docker from scratch.
That's a good point. I'd mentioned something similar before in my "aside" of #14245 (comment). I'll make a note of this in the parent issue #15159.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #15159, #14289 (comment)
This pull request seeks to double the number of Travis jobs dedicated to running end-to-end tests. In other words, it distributes the number of tests across 4 containers (vs. 2 previously) for each of the "Admin with plugins" and "Author without plugins" variations.
The desired effect here is that the total duration of a build decreases, since the number of end-to-end tests handled by any one Travis container will have lessened by a half.
To the potential question of whether "more containers" is okay or not, see also #14289 (comment) .
Testing Instructions:
Verify that the build passes.