Skip to content

RSS Block: support className attribute#13561

Closed
Soean wants to merge 5 commits intomasterfrom
update/rss-classname
Closed

RSS Block: support className attribute#13561
Soean wants to merge 5 commits intomasterfrom
update/rss-classname

Conversation

@Soean
Copy link
Member

@Soean Soean commented Jan 29, 2019

Description

Adds the custom className attribute to the RSS block.
Also orders the attributes in a alphabetical order.

@Soean Soean added the [Block] RSS Affects the RSS Block - used to display entries from an RSS/Atom feed label Jan 29, 2019
@gziolo gziolo requested review from ajitbohra and gziolo January 30, 2019 08:12
@gziolo gziolo added the [Type] Bug An existing feature does not function as intended label Jan 30, 2019
@gziolo gziolo added this to the 5.0 (Gutenberg) milestone Jan 30, 2019
@gziolo gziolo added the Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code label Jan 31, 2019
@codebykat codebykat self-requested a review March 9, 2019 18:23
Copy link
Contributor

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to rebase this because I was getting "The editor has encountered an unexpected error" for whatever reason. But after a rebase and applying the suggested change by @noisysocks it is working great!

Testing steps I followed:

  1. Add an RSS block to a post
  2. Add a URL and click "Use URL"
  3. Add an Additional CSS Class under Advanced
  4. Update the post and verify that the class name was added, along with wp-block-rss
  5. Delete the class name, update the post and verify that the class name is set to only wp-block-rss (with no empty spaces in the DOM).

@youknowriad youknowriad removed this from the 5.3 (Gutenberg) milestone Mar 18, 2019
Co-Authored-By: Soean <soerenwrede@gmail.com>
@Soean
Copy link
Member Author

Soean commented Mar 26, 2019

merged in #14533

@Soean Soean closed this Mar 26, 2019
@youknowriad youknowriad deleted the update/rss-classname branch March 26, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] RSS Affects the RSS Block - used to display entries from an RSS/Atom feed Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants