Not working with Micropython v1.23.0 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
This is an update to the fix requested for this issue and contains corections for issues I picked up when testing the open pull request
Tested on an ESP32 device
Changes are to CREATE, PATCH, GET and send_request - other methods may still have issues, I haven't had the chance to look at those
I was also thinking it might be nice to align this with the micropython auth library by shadowing standard python json and requests packages as that project does. Additional to this would be a rename of json.py, as it also shadows the name of the standard lib json package - but I don't want to put all that in this fix