[NJ][Feature][IOS] Solved a get error on the last version of MicroPython #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregSym
reviewed
Jan 4, 2025
|
|
||
| response = urequests.request(method, path, data=params, json=data, headers=headers) | ||
| if method == "POST": | ||
| response = urequests.request(method, path, data=None, json=data) |
GregSym
reviewed
Jan 4, 2025
| headers["Authorization"] = "Bearer " + FIREBASE_GLOBAL_VAR.ACCESS_TOKEN | ||
|
|
||
| response = urequests.request(method, path, data=params, json=data, headers=headers) | ||
| if method == "POST": |
There was a problem hiding this comment.
Also worth noting that the patch function should be a "PATCH" method to work properly (this may be a new thing, this is such an old pull request that it may predate it)
GregSym
reviewed
Jan 4, 2025
| LOCAL_OUTPUT = send_request(PATH+LOCAL_PARAMS, "post", data=DATA) | ||
| LOCAL_PARAMS += "updateMask=" + field | ||
| DATA = DOC.process() | ||
| LOCAL_OUTPUT = send_request(PATH, "POST", data=DATA) |
There was a problem hiding this comment.
Here one would need to use a PATCH method and the updateMask.fieldPaths notation is correct in the original, it just needs proper ampersand joining as the to_url_params function supports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Traceback (most recent call last):
File "", line 17, in
File "/lib/ufirestore/ufirestore.py", line 229, in get
File "/lib/ufirestore/ufirestore.py", line 104, in get
File "/lib/ufirestore/ufirestore.py", line 52, in send_request
TypeError: unexpected keyword argument 'params'
Issue: #1