Fix: deserializing nested objects #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ReflectionExtractor to get the type of nested fields from their types. This also breaks GET payloads, since all of their types are "string", because they are transported using a query string. Without the ReflectionExtractor, the discovered type was `null` and the value was coalesced to whatever the class had. With it, the correct type is discovered, but a mismatch happens, because all input types are "string". Adding `csv` format when deserializing GET payloads triggers the type juggling/coalescing inside of the ObjectNormalizer and everything starts working again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ReflectionExtractor to get the type of nested fields from their types. This also breaks GET payloads, since all of their types are "string", because they are transported using a query string. Without the ReflectionExtractor, the discovered type was
nulland the value was coalesced to whatever the class had. With it, the correct type is discovered, but a mismatch happens, because all input types are "string". Addingcsvformat when deserializing GET payloads triggers the type juggling/coalescing inside of the ObjectNormalizer and everything starts working againTrello card: n/a
Does this PR affect any security-relevant code?: no
Please consider Conventional Comments when commenting on PRs