Skip to content

Delete app/src/main/res/values-id directory#93

Open
TheRebo wants to merge 1 commit intoWirelessAlien:masterfrom
TheRebo:delete-values-id
Open

Delete app/src/main/res/values-id directory#93
TheRebo wants to merge 1 commit intoWirelessAlien:masterfrom
TheRebo:delete-values-id

Conversation

@TheRebo
Copy link
Contributor

@TheRebo TheRebo commented Feb 20, 2026

Because it turns out that the correct code is “values-in,” for backward compatibility.
Sorry, my fault. (Although “in” should be the code for India...)

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @TheRebo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an incorrect localization setup by removing the values-id directory. The author identified that values-in is the appropriate locale code for Indonesian language resources, especially for backward compatibility, thus rendering the values-id directory obsolete.

Highlights

  • Locale Code Correction: The values-id directory, which contained Indonesian string resources, has been removed. This is due to the discovery that the correct locale code for Indonesian, for backward compatibility, is values-in.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • app/src/main/res/values-id/strings.xml
    • Removed the file due to incorrect locale code usage.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the app/src/main/res/values-id/strings.xml file, which contained Indonesian language strings. The description indicates this is due to an incorrect language code, and that values-in should be used for backward compatibility. The change itself is straightforward, removing a file as intended. No issues were found with the removal of this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant