fix backward navigation on ctrl+f search bar #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stklcode
changed the title
With scoped enums in Qt6 a click on the "up" button, i.e. search
backwards causes pykib to crash with an error
AttributeError: type object 'OWebEnginePage' has no attribute
'FindBackward'
Passing the qualified enum value QWebEnginePage.FindFlag.FindBackward
resolves this issue.
stklcode
force-pushed
the
fix/findBackward
branch
from
2c9a758 to
9ba0d32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Using the search bar and trying to navigate backwards (click on the "up" button) causes the browser process to crash instantly with the following exception:
Expected behavior should be pretty obvious.
Steps to reproduce
Found on a RangeeOS 12 system running Pykib v3.0.43. Should apply to the latest version as well.
Analysis
With scoped enums in Qt6 the shortcut
QWebEnginePage.FindBackwardis no longer valid.Proposed fix
Passing the qualified enum value
QWebEnginePage.FindFlag.FindBackward1 to thefindText()call seems to resolve this issue.Footnotes
https://doc.qt.io/qt-6/qwebenginepage.html#FindFlag-enum ↩