Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .brev/setup.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
#!/bin/bash
set -e

# Brev Doctor Auto-Generated Setup Script
# Generated: 2025-12-25T09:19:29.817Z

echo '🚀 Setting up Brev environment...'

docker build --pull --no-cache --tag circuit_training:gpu --build-arg base_image=nvidia/cuda:11.8.0-cudnn8-devel-ubuntu22.04 --build-arg tf_agents_version='tf-agents-nightly[reverb]' --build-arg dreamplace_version='dreamplace_20231214_c5a83e5_python3.9.tar.gz' -f tools/docker/ubuntu_circuit_training ./tools/docker/
docker run --rm --gpus all -v $(pwd):/workspace --workdir /workspace circuit_training:gpu bash tools/e2e_smoke_test.sh --root_dir /workspace/logs
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unquoted command substitution breaks on paths with spaces

The $(pwd) in the docker volume mount -v $(pwd):/workspace is unquoted. If the current working directory contains spaces or special characters, bash will perform word splitting and the docker command will fail with a confusing error. This needs to be quoted as "$(pwd)" to handle paths with spaces correctly.

Fix in Cursor Fix in Web

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing logs directory creation before smoke test

The script runs the smoke test with --root_dir /workspace/logs but doesn't create the logs directory first. The smoke test script writes to files like ${ROOT_DIR}/reverb.log, which will fail if the directory doesn't exist. The README documentation shows a required mkdir -p logs step before running the docker container that's missing from this script.

Fix in Cursor Fix in Web

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPU resources provisioned but not used for training

The configuration provisions 4x H100 GPUs but the smoke test command doesn't include --use_gpu True, so training runs on CPU by default. The tools/README.md shows that --use_gpu True is needed when running on GPU hardware. Without this flag, expensive GPU resources are allocated but not actually used for training, wasting compute resources.

Additional Locations (1)

Fix in Cursor Fix in Web


echo '✅ Setup complete!'
22 changes: 22 additions & 0 deletions brev-launchable.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Brev.dev Launchable Configuration
# Generated by Brev Doctor

name: brev-launchable
version: "1.0"

compute:
gpu: H100
gpuCount: 4
vram: 80GB
architecture: Hopper

requirements:
estimatedVram: 80GB
cpuCores: 32
systemRam: 256GB
diskSpace: 500GB

setup:
script: .brev/setup.sh

# Launch this environment at https://brev.dev