added options to Network.add_nodes to match Network.add_node#158
Open
JackBarker7 wants to merge 2 commits intoWestHealth:masterfrom
Open
added options to Network.add_nodes to match Network.add_node#158JackBarker7 wants to merge 2 commits intoWestHealth:masterfrom
JackBarker7 wants to merge 2 commits intoWestHealth:masterfrom
Conversation
Author
|
@BerserkerGaruk @jhunpingco Would it be possible for one of you guys to review this request when you get a moment? Thanks :) |
boludo00
requested changes
Nov 22, 2022
Collaborator
boludo00
left a comment
boludo00
left a comment
There was a problem hiding this comment.
@JackBarker7 can you bring in the "color" as well? Pytest is failing on kwarg check.
Added "color" parameter as requested
Author
|
@boludo00 sorry for taking so long to get around to this, I've just updated it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thanks for writing such a useful library!
I've noticed that the
Network.add_nodesmethod is missing keyword argument options thatNetwork.add_nodehas. In order to bring the two functions in line with each other, I updated thevalid_argslist to contain the full set of options.