Refactor Webex integration and enhance UI components#21
Merged
Conversation
Contributor
adamweeks
commented
Dec 18, 2025
adamweeks
commented
- Updated App component to conditionally load Webex based on route.
- Modified CreateLobby to include a checkbox for enabling/disabling Webex integration.
- Enhanced LandingPage with two buttons for launching a game: one for Webex and one for standalone browser.
- Updated Navbar to display Webex info only on game routes.
- Adjusted LobbyProvider to preserve the disableWebex query parameter in the lobby URL.
- Updated useWebex hook to manage Webex loading based on the current route and query parameters.
- Added tests for new button functionality in LandingPage.
- Updated App component to conditionally load Webex based on route. - Modified CreateLobby to include a checkbox for enabling/disabling Webex integration. - Enhanced LandingPage with two buttons for launching a game: one for Webex and one for standalone browser. - Updated Navbar to display Webex info only on game routes. - Adjusted LobbyProvider to preserve the disableWebex query parameter in the lobby URL. - Updated useWebex hook to manage Webex loading based on the current route and query parameters. - Added tests for new button functionality in LandingPage.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
- Cleaned up spacing in App, CreateLobby, and Navbar components for better code clarity. - Enhanced LandingPage button structure for improved formatting. - Updated tests for LandingPage to reflect changes in button structure and ensure functionality. - Adjusted useWebex hook to maintain consistent formatting and improve readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.