230 signature base serialization fix#231
Open
da-tychinin wants to merge 4 commits intoWebOfTrust:mainfrom
Open
230 signature base serialization fix#231da-tychinin wants to merge 4 commits intoWebOfTrust:mainfrom
da-tychinin wants to merge 4 commits intoWebOfTrust:mainfrom
Conversation
* added optional authority parameter for authing methods. * removed Signer calls from httping. moved them to the upper level (authing) * refactor siginput and desiginput method to make them reflect each other * desiginput return value changed to map by signature label. According to the RFC the labels must be unique * added sigbase method to httping. It is now used in both sign and verify authing functions * authing.test.ts: mock httping methods. * added RFC test cases
Author
|
I've fixed the error TS5097 for "build, lint and test" stages. Should work fine now. Integration test will fail because of the different signature-base serialization |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
==========================================
+ Coverage 82.86% 82.89% +0.03%
==========================================
Files 46 46
Lines 4190 4157 -33
Branches 1044 1034 -10
==========================================
- Hits 3472 3446 -26
+ Misses 689 682 -7
Partials 29 29 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Looks like we'll need to close this PR soon. There's some good work here though it needs to be reworked with the latest Signify version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #230