Cesride-wasm integration example e2e#149
Closed
daidoji wants to merge 4 commits intoWebOfTrust:developmentfrom
Closed
Cesride-wasm integration example e2e#149daidoji wants to merge 4 commits intoWebOfTrust:developmentfrom
daidoji wants to merge 4 commits intoWebOfTrust:developmentfrom
Conversation
Implementation example of dater in signify-ts. Right now it just uses a package dependency and a mixture of cesr components from the cesride crate with some constants from signify-ts itself. This is just an example to show the integration works. Also doesn't have feature flags and the dependency is hardcoded into the package.json. dater tests are transcribed into jest from keripy test_dater() Also some todos to be figured out later.
Contributor
Author
|
Note: Tests don't pass because I didn't work out the dependency issue on cesride-wasm. |
Member
|
What's the intention of this PR? Perhaps this work would be better on a fork if you just want a place to show how it could work. |
Contributor
Author
|
@pfeairheller oh sorry, the intention was to demonstrate that cesride-wasm could be imported into signify-ts and would pass a unit test of js code proving interoperability. I'm not sure if I have the ability to create a branch on this repo but that would be fine by me if one was created and I can push this there. |
Contributor
Author
|
Closed. Implementation exists on daidoji/signify-ts if future generations are interested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR representing an e2e integration with cesride-wasm that corresponds with this PR in cesride:
WebOfTrust/cesride#155
It uses the dater implementation from cesride-wasm to execute tests in signify-ts that correspond to the test_dater() tests in keripy that have been transcribed into jest.
Note: todos are due to deviations from keripy/signify-ts calling conventions and the current cesride implementation. Also for future work is getting javascript options objects and destructuring to work so there's a better calling convention than
new Dater(dts, undefined, undefined, ...