fix: resolve clippy warnings#172
Open
seriouscoderone wants to merge 3 commits intoWebOfTrust:mainfrom
Open
Conversation
The `dat!` macro is already available crate-wide via `#[macro_use]` on the data module in lib.rs. These explicit imports are redundant and cause compilation failures with `#![deny(warnings)]`. Removes unused imports from: - src/core/common.rs (module and test) - src/core/creder.rs - src/core/pather.rs (test) - src/core/prefixer.rs (test) - src/core/sadder.rs (test) - src/core/saider.rs (module and test) - src/core/serder.rs - src/core/tholder.rs - src/data.rs (test) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Replace deprecated actions-rs/toolchain with dtolnay/rust-toolchain - Update actions/checkout to v4 - Add cargo caching for faster builds - Split into parallel jobs (check, audit, wasm) - Remove cargo-outdated (too strict for contributions) - Remove tarpaulin (can be added later with proper setup) - Install cargo-audit before running audit Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove empty line after doc comment in indexer/tables.rs - Use `if let` instead of `is_some()`/`is_ok()` + `unwrap()` pattern - Replace manual `% 3 != 0` with `.is_multiple_of(3)` - Replace manual `(n + 3) / 4` with `.div_ceil(4)` - Remove unneeded `return` statement in pather.rs These fixes allow `cargo clippy -- -D warnings` to pass, enabling strict clippy checks in CI. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
seriouscoderone
requested review from
jasoncolburne and
m00sey
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve all clippy warnings to enable strict
cargo clippy -- -D warningsin CI.Changes
src/core/indexer/tables.rssrc/core/indexer/mod.rsif letinstead ofis_some()+unwrap()src/core/indexer/mod.rs.is_multiple_of(3)instead of% 3 != 0src/core/indexer/mod.rs.div_ceil(4)instead of(n + 3) / 4src/core/matter/mod.rs.is_multiple_of(3)and.div_ceil(4)src/core/pather.rsreturnstatementsrc/core/tholder.rsif let Ok(value)instead ofis_ok()+unwrap().github/workflows/test.yml-D warnings)Test plan
cargo clippy -- -D warningspassescargo testpasses (832 tests)cargo fmt --checkpasses🤖 Generated with Claude Code