Changed to non deprecated removes that should have same effect as old…#167
Open
Changed to non deprecated removes that should have same effect as old…#167
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
=======================================
Coverage 95.42% 95.42%
=======================================
Files 32 32
Lines 3037 3037
=======================================
Hits 2898 2898
Misses 139 139 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Not really sure why these didn't show up in my old env but in my new env got deprecation warnings about map.remove being deprecated and to use swap or shift remove to be explicit about behavior.
Switched to something that seemed to fit with old code and tests still pass.
Testing
Tests remain same, no change to behavior.
For Reviewers
Cargo.toml