[binary-reader] Re-use ReadExternalKind for import as well as exports. NFC #2684
+41
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. NFC Another refactor to prepare for compact imports. I don't feel strongly about `malformed import kind` vs `invalid import external kind` but we should probably be consistent between imports and exports.
sbc100
force-pushed
the
ReadExternalKind
branch
from
f39bff6 to
fd19083
Compare
Member
Author
|
See #2685 which depends on this change. |
dschuff
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another refactor to prepare for compact imports.
I don't feel strongly about
malformed import kindvsinvalid import external kindbut we should probably be consistent between imports and exports.