Skip to content

install.sh Support single leading tilde in prefix (without using eval, replacement for #24)#26

Open
SuzanneSoy wants to merge 1 commit intoWayfireWM:masterfrom
SuzanneSoy:patch-tilde-prefix
Open

install.sh Support single leading tilde in prefix (without using eval, replacement for #24)#26
SuzanneSoy wants to merge 1 commit intoWayfireWM:masterfrom
SuzanneSoy:patch-tilde-prefix

Conversation

@SuzanneSoy
Copy link
Contributor

See #24 for details; this method does not use eval and shouldn't have problems with other special characters than ~ (it doesn't support ~username or a lone ~, adding those would be easy but they are unlikely to be used in practice.

@soreau
Copy link
Member

soreau commented Mar 10, 2021

See #24 for details; this method does not use eval and shouldn't have problems with other special characters than ~ (it doesn't support ~username or a lone ~, adding those would be easy but they are unlikely to be used in practice.

Might as well fix these potential cases while you're at it since they are known 'gotchas'.

@SuzanneSoy
Copy link
Contributor Author

I'm busy right now but I'm making a note to fix the conflicts and the other ~ use cases this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants