ext_toplevel_state: new protocol implementation#2909
Draft
dkondor wants to merge 3 commits intoWayfireWM:masterfrom
Draft
ext_toplevel_state: new protocol implementation#2909dkondor wants to merge 3 commits intoWayfireWM:masterfrom
dkondor wants to merge 3 commits intoWayfireWM:masterfrom
Conversation
Based on the draft protocol
Keeping track of outputs, always on top, sticky states
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the wlroots draft implementation of the protocol by @tokyo4j (available here), backported to wlroots 0.19: https://github.com/dkondor/wlroots/tree/ext_toplevel
Note: this is currently a bit incomplete (output information is not sent and additional states like always on top are not supported); I'll update it as I have some time. Also, currently, the -state protocol is always enabled -- it could make sense to add a setting for it in case a user would like to only expose the -info protocol.
I've tested so far only briefly with my Cairo-Dock implementation of the same protocol:
Cairo-Dock/cairo-dock-core#192
and will test more in the coming weeks.