carpet: add dual scroll animation effect#328
Merged
soreau merged 8 commits intoWayfireWM:masterfrom Dec 18, 2025
Merged
Conversation
soreau
requested changes
Dec 17, 2025
Member
soreau
left a comment
There was a problem hiding this comment.
It looks decent at a glance and judging from your video. However we need to take special care in the shaders regarding whitespace, since uncrustify doesn't enforce anything there. Also, the metadata xml should be fixed to make it more obvious what these new options do.
soreau
reviewed
Dec 18, 2025
Co-authored-by: Scott Moreau <oreaus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new scroll animation modes that simulate an ancient scroll unrolling
from both sides toward the middle.
Two new direction options:
The effect creates two synchronized rolls that start at opposite edges
and meet in the middle when opening, and roll back outward from the
center when closing.