upstream sync #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ruby-3.3.8
Update CRuby releases on Windows
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes the repository with upstream changes, updating version references and CI configurations to match the latest supported environments.
- Updated Ruby and JRuby version ranges in the README.
- Added additional notes on runner image/version combinations in the README.
- Modified the CI workflow to remove ubuntu-20.04 and use ubuntu-22.04 across jobs.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Updated Ruby and JRuby version references and added notes. |
| .github/workflows/test.yml | Adjusted OS matrix and runner settings to remove ubuntu-20.04. |
Files not reviewed (2)
- ruby-builder-versions.json: Language not supported
- windows-versions.json: Language not supported
Comments suppressed due to low confidence (3)
.github/workflows/test.yml:20
- The removal of ubuntu-20.04 from the OS matrix may reduce test coverage for older environments. If legacy support is no longer required, consider updating any related documentation to reflect this change.
os: [ ubuntu-22.04, ubuntu-24.04, ubuntu-22.04-arm, ubuntu-24.04-arm, macos-13, macos-14, macos-15, windows-2019, windows-2022, windows-2025 ]
.github/workflows/test.yml:289
- Updating the runner for the 'testFixedBundlerVersionForOldRuby' job to ubuntu-22.04 might affect testing on older Ruby versions. Verify that the new environment meets all testing requirements for legacy builds.
runs-on: ubuntu-22.04
.github/workflows/test.yml:414
- Changing the lint job's runner to ubuntu-22.04 may result in different behavior compared to ubuntu-20.04. Ensure that linting outcomes remain consistent across environment updates.
runs-on: ubuntu-22.04
suryaoruganti
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.