Conversation
Use double arrows for two-way edges, single arrows for one-way. Color single arrows red and double arrows green.
AjaiKN
commented
May 25, 2021
|
|
||
| workbox.precaching.precacheAndRoute( | ||
| precacheManifest.filter( | ||
| (p) => !p.url.includes("graphpage") && !p.url.includes("legacy") |
Member
Author
There was a problem hiding this comment.
This is so that the service worker doesn't ask the browser to precache the resources for the graph page, since most people will never go to that page.
Member
Author
|
Although the service worker isn't precaching the graph page, Vue CLI is still adding prefetch headers that we need to remove, which ask the browser to prefetch those resources in the future. This is bad because most people will never go to the graph page. <link href="/css/graphpage.f6b6efdf.css" rel="prefetch">
<link href="/js/graphpage.8a39efaa.js" rel="prefetch">This should be fixed before merging. (If we decide to merge it at all; this obviously isn't a very important change, it's just a visualization to help people understand how Walnut.Direct works.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://graph.walnut.direct/graph