fix: add ON DELETE cascade/set-null rules to FK relationships#198
Open
jakebromberg wants to merge 2 commits intomainfrom
Open
fix: add ON DELETE cascade/set-null rules to FK relationships#198jakebromberg wants to merge 2 commits intomainfrom
jakebromberg wants to merge 2 commits intomainfrom
Conversation
9 tasks
Most FK relationships defaulted to NO ACTION, blocking legitimate operations like user deletion. Added appropriate cascade rules. Co-authored-by: Cursor <cursoragent@cursor.com>
3b9f799 to
35a9b53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wxyc_schematables defaulted toON DELETE NO ACTION, blocking legitimate operations like deleting users or schedule entries when child rows exist.onDelete: 'set null'to 8 FK columns where the child row should be preserved (schedule DJ assignments, flowsheet entries, show primary DJ, shift cover DJ).onDelete: 'cascade'to 7 FK columns where the child row is meaningless without the parent (rotation/review entries, cross-reference tables, show_djs.show_id).tests/unit/database/schema.fk-cascades.test.ts) that asserts correctonDeleterules for all 19 FK relationships.Test plan
onDeleteruleonDelete(NO ACTION)Closes #38
Made with Cursor