fix: remove redundant .unique() on anonymous_devices.deviceId#197
Open
jakebromberg wants to merge 2 commits intomainfrom
Open
fix: remove redundant .unique() on anonymous_devices.deviceId#197jakebromberg wants to merge 2 commits intomainfrom
jakebromberg wants to merge 2 commits intomainfrom
Conversation
The column had both .unique() and an explicit uniqueIndex, creating two identical indexes. Kept the explicit uniqueIndex for naming control. Co-authored-by: Cursor <cursoragent@cursor.com>
jakebromberg
force-pushed
the
fix/37-redundant-index
branch
from
7b24354 to
04dcc81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
anonymous_devicestable had both.unique()on thedeviceIdcolumn and an explicituniqueIndex('anonymous_devices_device_id_key')in the table's third argument, creating two redundant unique indexes ondevice_id..unique()and kept the explicituniqueIndexfor naming control.device_id.Test plan
tests/unit/database/schema.anonymous-devices.test.tsfails before fix (count = 2) and passes after (count = 1)npm run test:unit)Made with Cursor