fix: add unique constraint on show_djs (show_id, dj_id)#195
Open
jakebromberg wants to merge 2 commits intomainfrom
Open
fix: add unique constraint on show_djs (show_id, dj_id)#195jakebromberg wants to merge 2 commits intomainfrom
jakebromberg wants to merge 2 commits intomainfrom
Conversation
The junction table had no uniqueness constraint, allowing a DJ to be inserted into the same show multiple times. Co-authored-by: Cursor <cursoragent@cursor.com>
jakebromberg
force-pushed
the
fix/21-show-djs-unique
branch
from
1adb273 to
a695b5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uniqueIndexon(show_id, dj_id)to theshow_djsjunction table to prevent duplicate DJ-show pairingsTest plan
schema.show-djs.test.tsfails before the fix and passes afternpm run test:unit)Closes #21
Made with Cursor