fix: add NOT NULL constraints to artist_library_crossreference FK columns#194
Open
jakebromberg wants to merge 3 commits intomainfrom
Open
fix: add NOT NULL constraints to artist_library_crossreference FK columns#194jakebromberg wants to merge 3 commits intomainfrom
jakebromberg wants to merge 3 commits intomainfrom
Conversation
All create endpoints (flowsheet entries, bin entries, albums, artists, rotation, formats, genres, schedule) returned 200 instead of 201. Co-authored-by: Cursor <cursoragent@cursor.com>
jakebromberg
force-pushed
the
fix/20-crossref-notnull
branch
from
0230c92 to
4d0d0c2
Compare
jakebromberg
force-pushed
the
fix/20-crossref-notnull
branch
from
fbd8f53 to
ed77db3
Compare
The 201 status code changes from commit 46f729f were accidentally introduced during a rebase and do not belong in this PR, which is about adding NOT NULL constraints to artist_library_crossreference FK columns. Reverts all controllers to return 200 for create endpoints and removes the associated unit test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.notNull()to bothartist_idandlibrary_idFK columns in theartist_library_crossreferencejunction table, matching the pattern used bygenre_artist_crossreference.NULL != NULLin SQL..notNull().Test plan
tests/unit/database/schema.crossref.test.tsconfirms both FK columns have.notNull()Made with Cursor