fix: batch database queries in getPlaylistsForDJ to eliminate N+1#191
Open
jakebromberg wants to merge 2 commits intomainfrom
Open
fix: batch database queries in getPlaylistsForDJ to eliminate N+1#191jakebromberg wants to merge 2 commits intomainfrom
jakebromberg wants to merge 2 commits intomainfrom
Conversation
Replaced sequential per-show queries with batched IN queries, reducing ~4N queries to ~5 constant queries. Co-authored-by: Cursor <cursoragent@cursor.com>
jakebromberg
force-pushed
the
fix/29-playlist-n-plus-1
branch
from
9f61e78 to
0ea5a6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getPlaylistsForDJ: the previous implementation ran 3-4 sequential DB queries per show inside aforloop, resulting in ~4N queries for N shows (e.g., 17 queries for 5 shows).INqueries usinginArrayfrom drizzle-orm: one query each for shows, show DJs, specialty shows, and flowsheet entries, then assembles results in JS. Total: ~5 constant queries regardless of show count.db.select()is called at most 6 times for 5 shows, catching any regression back to O(N) queries.Test plan
djs.getPlaylistsForDJ.test.tsverifies query count is bounded (≤6 for 5 shows)ShowPeekshapeGET /djs/:id/playlistson staging and confirm response shape is unchangedMade with Cursor