fix: default cookie sameSite to 'lax' instead of 'none'#190
Open
jakebromberg wants to merge 2 commits intomainfrom
Open
fix: default cookie sameSite to 'lax' instead of 'none'#190jakebromberg wants to merge 2 commits intomainfrom
jakebromberg wants to merge 2 commits intomainfrom
Conversation
sameSite: 'none' sends cookies on all cross-site requests, weakening CSRF protection. Defaulting to 'lax' while allowing env override. Co-authored-by: Cursor <cursoragent@cursor.com>
jakebromberg
force-pushed
the
fix/31-cookie-samesite
branch
from
c7e8f68 to
01ee215
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sameSite: 'none'inshared/authentication/src/auth.definition.tssends cookies on all cross-site requests, weakening CSRF protection.sameSiteto'lax'while allowing override viaCOOKIE_SAME_SITEenv var for deployments that need cross-origin cookie behavior.sameSiteis never hardcoded to'none'.Closes #31
Test plan
sameSite: 'none'value'lax')laxsettingCOOKIE_SAME_SITE=noneenv override works for cross-origin deploymentsMade with Cursor