fix: prevent SSH timeout stacking in MirrorSQL#189
Open
jakebromberg wants to merge 2 commits intomainfrom
Open
fix: prevent SSH timeout stacking in MirrorSQL#189jakebromberg wants to merge 2 commits intomainfrom
jakebromberg wants to merge 2 commits intomainfrom
Conversation
Each sshInstance() call added a new 5-minute timeout without clearing the previous one, stacking dangling timeouts on rapid repeated calls. Co-authored-by: Cursor <cursoragent@cursor.com>
9d80d0c to
3c6f4f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sshInstance()call inMirrorSQLcreated a new 5-minutesetTimeoutwithout clearing the previous one, causing dangling timeouts to stack on rapid repeated calls.clearTimeouton the existing handle before setting a new one.Test plan
tests/unit/middleware/legacy/ssh-timeout.test.ts— confirmsclearTimeoutis called on prior handles and that only the latest timeout firesdispose().npm run test:unit).Fixes #36
Made with Cursor