fix: add authentication to POST /schedule endpoint#179
Open
jakebromberg wants to merge 1 commit intomainfrom
Open
fix: add authentication to POST /schedule endpoint#179jakebromberg wants to merge 1 commit intomainfrom
jakebromberg wants to merge 1 commit intomainfrom
Conversation
POST /schedule had no auth middleware, allowing anonymous users to insert arbitrary schedule entries. Added requirePermissions check using flowsheet:write permission since no schedule-specific resource is defined. Added unit test and auth mock infrastructure. Co-authored-by: Cursor <cursoragent@cursor.com>
3c3364d to
fb85abf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /schedulehad no authentication middleware, allowing anonymous users to insert arbitrary schedule entriesrequirePermissions({ flowsheet: ['write'] })middleware to the POST route, matching the pattern used by flowsheet and other write endpoints@wxyc/authenticationmock andschedule/NewShiftexports to the database mock for unit testing routes that use auth middlewareTest plan
Made with Cursor