fix: return 400 instead of 404 in leaveShow when no active show

apps/backend/controllers/flowsheet.controller.ts

@@ -327,7 +327,7 @@ export const joinShow: RequestHandler = async (req: Request<object, object, Join
 export const leaveShow: RequestHandler<object, unknown, { dj_id: string }> = async (req, res, next) => {
   const currentShow = await flowsheet_service.getLatestShow();
   if (currentShow?.end_time !== null) {
-    res.status(404).json({ message: 'Bad Request: No active show session found.' });
+    res.status(400).json({ message: 'Bad Request: No active show session found.' });
   } else {
     try {
       // Catch case where DJ is not in show, but attempting to hit this endpoint

tests/integration/flowsheet.spec.js

@@ -84,7 +84,7 @@ describe('End Show', () => {
       .send({
         dj_id: global.secondary_dj_id,
       })
-      .expect(404);
+      .expect(400);
     expect(res.body.message).toBeDefined();
   });
 });
@@ -139,7 +139,7 @@ describe('Leave Show', () => {
       .send({
         dj_id: global.secondary_dj_id,
       })
-      .expect(404);
+      .expect(400);
     expect(res.body.message).toBeDefined();
   });
 });

tests/unit/controllers/flowsheet.leaveShow.test.ts

@@ -0,0 +1,53 @@
+import { jest } from '@jest/globals';
+
+const mockGetLatestShow = jest.fn();
+
+jest.mock('../../../apps/backend/services/flowsheet.service', () => ({
+  getLatestShow: mockGetLatestShow,
+}));
+
+jest.mock('../../../apps/backend/services/metadata/index', () => ({
+  fetchAndCacheMetadata: jest.fn(),
+}));
+
+jest.mock('async-mutex', () => ({
+  Mutex: jest.fn().mockImplementation(() => ({
+    acquire: jest.fn().mockResolvedValue(jest.fn()),
+  })),
+}));
+
+import { leaveShow } from '../../../apps/backend/controllers/flowsheet.controller';
+import type { Request, Response, NextFunction } from 'express';
+
+function createMockRes() {
+  const statusMock = jest.fn();
+  const jsonMock = jest.fn();
+  const res: Partial<Response> = {};
+  statusMock.mockReturnValue(res);
+  jsonMock.mockReturnValue(res);
+  res.status = statusMock as unknown as Response['status'];
+  res.json = jsonMock as unknown as Response['json'];
+  return { res: res as Response, statusMock, jsonMock };
+}
+
+describe('leaveShow', () => {
+  it('returns 400 when no active show session exists (end_time is set)', async () => {
+    mockGetLatestShow.mockResolvedValue({
+      id: 1,
+      primary_dj_id: 'dj-1',
+      start_time: new Date('2025-01-01'),
+      end_time: new Date('2025-01-01T02:00:00'),
+    });
+
+    const req = { body: { dj_id: 'dj-1' } } as Request;
+    const { res, statusMock, jsonMock } = createMockRes();
+    const next = jest.fn() as unknown as NextFunction;
+
+    await leaveShow(req, res, next);
+
+    expect(statusMock).toHaveBeenCalledWith(400);
+    expect(jsonMock).toHaveBeenCalledWith({
+      message: 'Bad Request: No active show session found.',
+    });
+  });
+});