Fix freezing parameter functionality #105
Merged
+18
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwalter2
force-pushed
the
260126_fixFreezingParameterFunctionality
branch
from
cf2f3c5 to
363b010
Compare
lucalavezzo
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For constrained nuisances the gradient was not stopped in the constraint term of the likelihood. The stop gradient for frozen parameter is now moved into the "get_theta()" and "get_poi()" functions and thus applied whenever it is called.
The "get_theta()" "get_poi()" function was also renamed, previously "get_blinded_theta()" and "get_blinded_poi()", to reflect the more general purpose.