Feature: Enable DataFrames in plant location_data inputs
#202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nRiccobo
approved these changes
Oct 30, 2025
Collaborator
nRiccobo
left a comment
nRiccobo
left a comment
There was a problem hiding this comment.
Thanks for adding this functionality and addressing the bug in the example. One note is that when I tried to run the example I got a NameError on plt from the plotting functions. Back in April, the matplotlib dependency was moved to optional. I adjusted the README file to address this.
Collaborator
|
I also added a print statement as part of the try/except in array_layout_design.py. Feel free to adjust or reject that piece if you think its unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to pass a DataFrame as the
config["plant"]["location_data"]input for theCustomArraySystemDesignmodel and fixes a bug in the usage ofnp.uniquewith variable length inputs. To accompany this, I've also updated the custom array layout example notebook to include an example of the direct passing of a DataFrame in the configuration dictionary. An additional cable has been added to the Dudgeon layouts to ensure there is enough carrying capacity following the previous bug fix.