[Spec] In-progress fenced frame navigation should be blocked if both navigated FF and initiator FF have network revoked#228
Merged
xiaochen-z merged 20 commits intoWICG:masterfrom Jun 16, 2025
Conversation
blu25
reviewed
Apr 4, 2025
Collaborator
Author
|
VergeA
approved these changes
Apr 16, 2025
Collaborator
VergeA
left a comment
There was a problem hiding this comment.
This LGTM % my one other comment.
K91AYAM
approved these changes
May 13, 2025
K91AYAM
approved these changes
May 13, 2025
K91AYAM
approved these changes
May 13, 2025
domfarolino
reviewed
Jun 2, 2025
domfarolino
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #173.
The overall implementation is:
is_embedder_initiated_fenced_frame_navigation_is set during FF.configsetter and passed down to the downstream navigation request.OnResponseStarted(), if root is FF and the above flag is set then:NavigationRequest::IsDisabledEmbedderInitiatedFencedFrameNavigation()) if both:This PR specs the blocking of navigation in
attempt to populate the history entry's documentbecause in Chromium just a few lines below the call toNavigationRequest::IsDisabledEmbedderInitiatedFencedFrameNavigation(), there is CheckResponseAdherenceToCoep(), which is spec'd inattempt to populate the history entry's document's step 5 substep 4. So I think it is reasonable to spec them in the same place.To check the navigation is an embedder-initiated fenced frame navigation, instead of adding a flag as it is implemented in Chromium, the following condition is checked, reused from the navigate algorithm patch.
fenced-frame/spec.bs
Lines 3550 to 3552 in cb57423
Preview | Diff