Conversation
mikewest
requested review from
antosart and
otherdaniel
and removed request for
antosart
Member
Author
|
WDYT, @otherdaniel? |
antosart
reviewed
Feb 16, 2026
otherdaniel
approved these changes
Feb 16, 2026
Collaborator
otherdaniel
left a comment
otherdaniel
left a comment
There was a problem hiding this comment.
Looks good!
Not entirely sure about PolicyControlledFeatureObserver, but the other names are exactly right.
This PR changes a few names in the document to shift away from the older 'permission element' concept: * `PermissionsMixin` => `PowerfulFeatureObserver`. * `[[PermissionElements]]` => `[[ActivationBlockableElements]]` * "permissions element" => more specific references to <geolocation>. No change in behavior is intended.
github-actions bot
added a commit
that referenced
this pull request
Feb 17, 2026
SHA: ecaf711 Reason: push, by mikewest Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Feb 17, 2026
SHA: ecaf711 Reason: push, by mikewest Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes a few names in the document to shift away from the older 'permission element' concept:
No change in behavior is intended.