Fix crashing in online matches #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dereferencing nullptr in online matches...
Contributor
Author
|
Also added settings as CVars to not have to set them every time 😅 |
If `DoubleJumpPressedTime` was set before, the check will return true, because time starts from 0 again.
This makes sense for accidential flipping, since one can still see the timing for the jump and pitch inputs afterwards.
- Allow configuring timings - Show pitch down in history (as an option) - Also record inputs after dodging (to also see timings/inputs when backflipping) - Calculate pitch up amount only between jumps - Allow toggling different parts of the UI - Draw a backdrop behind to whole UI (fully opaque by default) - Show cvars in console
This allows players to only measure the total jump duration (from first jump press to double jump press), which can be useful when training wall-dashes or speed-flips
For lower sizes the graphs sometimes overlap with the border. This way it look cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dereferencing nullptr...
@Vyncc Might want to add this to the new version 😅