-
-
Notifications
You must be signed in to change notification settings - Fork 0
Update dist command #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Update dist command #663
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe Changes
Possibly related PRs
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #663 +/- ##
===========================================
- Coverage 93.60% 92.29% -1.32%
===========================================
Files 57 68 +11
Lines 1173 1479 +306
Branches 181 247 +66
===========================================
+ Hits 1098 1365 +267
- Misses 75 109 +34
- Partials 0 5 +5 see 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
package.json(1 hunks)
🔇 Additional comments (1)
package.json (1)
19-19:Details
✅ Verification successful
Verify removal of node_modules copy from dist:react
The updated
dist:reactscript no longer copiesnode_modulesintobuild, which is ideal if Webpack bundles all dependencies. Please ensure that your extension functions correctly without external modules at runtime.Run this script to confirm no
node_modulesreferences remain:
🏁 Script executed:
#!/bin/bash # Verify no 'node_modules' references in the dist:react script jq -r '.scripts["dist:react"]' package.json | grep -q 'node_modules' \ && echo "❌ node_modules found in dist:react" \ || echo "✅ no node_modules references"Length of output: 135
Lines 19–19:
"dist:react": "ENABLE_REACT=true NODE_ENV=production npx webpack && cd build && zip -r ../dist/dist.zip . -x \"coverage*\" \"*/*.test.js\"",dist:react script no longer references node_modules – verified
The updated
dist:reactscript omits copyingnode_modules, which is correct since Webpack bundles all dependencies. Ran the verification script—nonode_modulesreferences found. ✅ Approved for merge.
What's Changed
Summary by CodeRabbit