Fix sensapex lib location #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Sensapex library location by renaming the DLL from libum.dll to um.dll to align with the actual library naming convention used by the Sensapex package. The change includes updating references across the codebase, documentation, and build configuration.
- Version bumped to 2.2.1 to reflect the fix
- Updated library name from
libum.dlltoum.dllacross spec file, documentation, and gitignore - Updated documentation links to use correct relative paths
- Updated multiple development dependencies to newer versions
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/ephys_link/__about__.py |
Version bump to 2.2.1 |
pyproject.toml |
Updated development and documentation dependencies to newer versions |
ephys_link.spec |
Updated Sensapex SDK path to use um.dll instead of libum.dll; improved hiddenimports syntax |
docs/development/jackhammer_mode.md |
Updated documentation to reference um.dll instead of libum.dll |
docs/development/adding_a_manipulator.md |
Fixed documentation links to use correct relative paths (../reference/ instead of ../../reference/) |
docs/assets/um.dll |
Added the Sensapex SDK binary file (v1.510) |
.gitignore |
Updated exception pattern from !libum.so to !um.so |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Notes