Skip to content

Use Font Awesome for close icon, make it optional #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chench53 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use Font Awesome for close icon, make it optional #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ If you are not using Font Awesome for icons, you should replace the icons with c
```javascript
spinnerIconURL: '',
noCommentsIconURL: '',
closeIconURL: '',
upvoteIconURL: '', // Only if upvoting is enabled
replyIconURL: '', // Only if replying is enabled
uploadIconURL: '', // Only if attachments are enabled
Expand Down
10 changes: 9 additions & 1 deletion js/jquery-comments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@
attachmentIconURL: '',
fileIconURL: '',
noCommentsIconURL: '',
closeIconURL: '',

// Strings to be formatted (for example localization)
textareaPlaceholderText: 'Add a comment',
Expand Down Expand Up @@ -1330,7 +1331,14 @@
// Close button
var closeButton = $('<span/>', {
'class': 'close inline-button'
}).append($('<span class="left"/>')).append($('<span class="right"/>'));
})

var closeIcon = $('<i class="fa fa-close"/>');
if (this.options.closeIconURL.length) {
closeIcon.css('background-image', 'url("'+this.options.closeIconURL+'")');
closeIcon.addClass('image');
}
closeButton.append(closeIcon);

// Save button text
if(existingCommentId) {
Expand Down