Hide keyboard on Price Check screen#69
Open
Roudique wants to merge 3 commits intoVeritasDev:release/1.3.0from
Open
Hide keyboard on Price Check screen#69Roudique wants to merge 3 commits intoVeritasDev:release/1.3.0from
Roudique wants to merge 3 commits intoVeritasDev:release/1.3.0from
Conversation
VeritasDev
reviewed
Aug 3, 2020
Comment on lines
94
to
96
| override func scrollViewDidScroll(_ scrollView: UIScrollView) { | ||
| searchBar.resignFirstResponder() | ||
| } |
Owner
There was a problem hiding this comment.
Perhaps we can replace this with scrollViewWillBeginDragging instead, as that will be called once upon scrolling as opposed to scrollViewDidScroll which is called a shitload during scrolling? Thoughts? Thanks for the PR!
Owner
There was a problem hiding this comment.
Also would want to re-target this PR to the release/1.3.0 branch if possible!
Author
|
@VeritasDev Updated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As of right now the UX with keyboard on Price Check screen is not very friendly, to be more precise there's no way to hide it:
This PR fixes this by hiding keyboard either on scrolling or when user presses "search":
Encourage you to try for yourself :)
UPD Lol PR #69 :D