Allow overwriting of getRelatedModel() method#393
Open
lukasleitsch wants to merge 1 commit intoVentureCraft:masterfrom
Open
Allow overwriting of getRelatedModel() method#393lukasleitsch wants to merge 1 commit intoVentureCraft:masterfrom
getRelatedModel() method#393lukasleitsch wants to merge 1 commit intoVentureCraft:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the relationship of a model don't follow the default Laravel naming the package can't identify the correct relationship. Therefore, the method
identifiableName()is not working:Issue: #270
The package allow in the config to define an own revision model. My idea is to define a custom revision model and extend the package model. In the custom model I would overwrite the
getRelatedModel()to adjust the logic to find the correct relationship.The PR changes the visibility of the method to allow an overwriting.