Restructured for psr-4 and composer.#313
Open
tarekadam wants to merge 36 commits intoVentureCraft:masterfrom
Open
Restructured for psr-4 and composer.#313tarekadam wants to merge 36 commits intoVentureCraft:masterfrom
tarekadam wants to merge 36 commits intoVentureCraft:masterfrom
Conversation
Pulling new code from head repository
AutoAccept added for revision creations enabled
…ider is autoloaded and provides migration to artisan
Author
|
Oh shit - I totally forgot to say thanks sharing!! |
# Conflicts: # composer.json # readme.md
* 'master' of github.com:dakshhmehta/revisionable: AutoAccept added for revision creations enabled Rollback code for autoAccept Rollback some error if its new record, then its probably we don't want to store it Moving code from one method to other Not null should not be part of the revision Fix the code to work for first time record creation Fixed revision issue while creation for autoAccept Added autoAccept parameter and revision limit by key
Contributor
|
Sadly it looks like the package author has abandoned it without adding a note to the package to let people know. Not sure this'll end up being merged so may be better to fork? |
Collaborator
|
@rickmills @tarekadam I will begin/resume maintaining this, although may end up moving the repository/namespace for a larger upgrade. I have already begun taking some of these PR's and pushing into a v2, and also begin to sunset support for older Laravel versions on v2 and onward 🙏 (Edit: And thank you for the contribution! I've skimmed over it once I realized this package needed some love again, but will dive into further soon!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, moved some files and tweaked composer.json for: