Cast the revisionable ID to a string to overcome issues with Uuids#191
Open
alexhouse wants to merge 1 commit intoVentureCraft:masterfrom
alexhouse:master
Open
Cast the revisionable ID to a string to overcome issues with Uuids#191alexhouse wants to merge 1 commit intoVentureCraft:masterfrom alexhouse:master
alexhouse wants to merge 1 commit intoVentureCraft:masterfrom
alexhouse:master
Conversation
|
It seems the primary key goes into the I'm not sure the best way to handle primary keys that don't happen to be automatically generated integers or whatever type that is assumed; some concerns including:
I guess it might be possible to have a somewhat large column (a text/a blob) to store the original primary key {stringified or otherwise encoded] and then hash the that to make the primary key (but this presumes a world where secure hashes don't have collisions). |
|
Hi all, I'm going to be maintaining a fork that has complete UUID support at https://github.com/joshbrw/revisionable-uuid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're currently using Revisionable in a project that has Uuids for primary keys. Without this change, the IDs keep getting cast to integers, which don't work