Impr: Fix Retire cert test 2nd attempt#617
Merged
marcos-albornoz merged 2 commits intomasterfrom Dec 11, 2025
Merged
Conversation
It was determined that the retire cert functionality can fail when the thumbprint is used. So the solution was to add a function that can attempt the cert retirement by a given times each n seconds.
marcos-albornoz
requested review from
EduardoVV,
luispresuelVenafi and
rvelaVenafi
as code owners
luispresuelVenafi
approved these changes
Dec 11, 2025
angelmoo
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was determined that the retire cert functionality can fail when the thumbprint is used. So the solution was to add a function that can attempt the cert retirement by a given times each n seconds.