Skip to content

Support TPP v25.1 and higher#551

Merged
marcos-albornoz merged 11 commits intomasterfrom
support-tpp-25.1
Apr 11, 2025
Merged

Support TPP v25.1 and higher#551
marcos-albornoz merged 11 commits intomasterfrom
support-tpp-25.1

Conversation

@stkomitov
Copy link
Contributor

No description provided.

@BeardedPrincess
Copy link
Collaborator

I this effort, it would be great if we could also merge or incorporate the changes from #527. I imagine the work to integrate the PKIX support will impact the certificate signing request modules which that PR had to tackle since the original/current code-base adds a couple of layers of abstraction from the crypto/x509 library.

@stkomitov
Copy link
Contributor Author

I this effort, it would be great if we could also merge or incorporate the changes from #527. I imagine the work to integrate the PKIX support will impact the certificate signing request modules which that PR had to tackle since the original/current code-base adds a couple of layers of abstraction from the crypto/x509 library.

Most of the TPP WebSDK API calls are backward compatible, so in my PR I would mostly handle the Policy Get/Set commands. The certificate API (request, renew, check policy...) is completely backward compatible with TPP < 25.1. So, your changes doesn't overlap with the changes in this PR, but our team will work on merging #527 and release it in the same vcert version, hopefully by the end of this week.
The full PKIX support and support for PQ algorithms would be introduced later.

@stkomitov stkomitov marked this pull request as ready for review April 8, 2025 14:12
@stkomitov stkomitov requested review from angelmoo and knikolov82 and removed request for rvelaVenafi April 8, 2025 14:12
@stkomitov stkomitov changed the title Support TPP v25.1 and higher (PKIX support) Support TPP v25.1 and higher Apr 8, 2025
@marcos-albornoz
Copy link
Contributor

Should it not be considered to do some update to include the PkixParameterSet as part of the PolicySpecification returned by the venafi.tpp.Connector.GetPolicy()?

@stkomitov
Copy link
Contributor Author

Should it not be considered to do some update to include the PkixParameterSet as part of the PolicySpecification returned by the venafi.tpp.Connector.GetPolicy()?

I added it because it is cleaner when we need to build the TPP policy in func BuildTppPolicy(ps *PolicySpecification) TppPolicy. Later we would need to update vcert to also store/read the PkixParameterSet attribute to/from files as well (policy as json/yaml), because TPP would only work with that attribute in later versions.

@marcos-albornoz marcos-albornoz merged commit c1d907d into master Apr 11, 2025
5 checks passed
@marcos-albornoz marcos-albornoz deleted the support-tpp-25.1 branch April 11, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants