Open
Conversation
Recommend removing store validation - use cases may vary from one enterprise to the next. If this can't be removed - I'd recommend adding WebHosting as it is designed to support SNI use cases
R3LentL355
requested review from
EduardoVV,
luispresuelVenafi,
marcos-albornoz and
rvelaVenafi
as code owners
BeardedPrincess
approved these changes
Aug 19, 2024
Collaborator
|
Would it be better to make store validation optional? I'm happy to contribute the code if there's value in keeping the option. |
Author
That would be helpful - I think that any sort of allow/deny "policy" such as this should be something we would consider as being user-configurable. |
Collaborator
|
Superceded by #524 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recommend removing store validation - use cases may vary from one enterprise to the next. If this can't be removed - I'd recommend adding WebHosting as it is designed to support SNI use cases